Triggering the bookend through the store. #14036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
approved these changes
Mar 15, 2018
| if (pageId === null) { | ||
| dispatch(this.element, EventType.SHOW_BOOKEND, /* opt_bubbles */ true); | ||
| return; | ||
| if (pageId) { |
There was a problem hiding this comment.
nit: slightly prefer
if (!pageId) {
return;
}
this.switchTo_(pageId);
gmajoulet
force-pushed
the
store_bookend
branch
from
5874193
to
946d1af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bookend is now triggered by
this.storeService_.dispatch(Action.TOGGLE_BOOKEND, boolean), and the code updating the UI reacts to the store mutations. We no longer have to propagate the bookend events across all the components.This will allow us to move all the bookend code into its own self contained component, which will be done in the next PR.