Remove vsync from parallax #14042
Merged
Remove vsync from parallax #14042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of ampproject#12748. This also puts the style mutations inside a mutation phase, since it affects the elements bounding box in the page.
aghassemi
reviewed
Mar 16, 2018
| this.translateYOffset_ = 0; | ||
|
|
||
| /** @private {boolean} */ | ||
| this.mutateScheduled_ = false; |
There was a problem hiding this comment.
this doesn't seem to change value
There was a problem hiding this comment.
What happened to the commits... Fixed.
| @@ -102,6 +102,14 @@ class ParallaxElement { | |||
|
|
|||
| /** @private @const {!Element} */ | |||
| this.element_ = element; | |||
|
|
|||
| /** @private {number} */ | |||
| this.translateYOffset_ = 0; | |||
There was a problem hiding this comment.
this seems to be only set and never read back
|
LGTM. Thank you for making these changes yourself as part of layout work. Much appreciated! |
aghassemi
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12748.
This also puts the style mutations inside a mutation phase, since it
affects the elements bounding box in the page.