Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AMP.printState even in non-dev mode #14052

Merged
merged 1 commit into from Mar 16, 2018

Conversation

josh313
Copy link
Contributor

@josh313 josh313 commented Mar 16, 2018

  • Enable AMP.printState even in non-dev mode

@choumx

@dreamofabear dreamofabear merged commit f3cd9b0 into ampproject:master Mar 16, 2018
@shishirm
Copy link

Hi @choumx, it seems like this change was reverted i.e. we've gone back to needing the #development=1 to get results back from printState() and without the #development=1, the return is "undefined".

Is this an expected change?

@dreamofabear
Copy link

Try adding #log=4 which will show all logs.

@shishirm
Copy link

Hello. I thought the expectation was to not require any log/development flag and for AMP.printState() to work automatically in the console?

Or would you like me to paste the output of #log=4 here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants