馃殌Improve Mediapool initialization by cloning nodes #14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
Mar 16, 2018
| const mediaEl = this.mediaFactory_[type].call(this); | ||
| mediaEl.setAttribute('pool-element', elId++); | ||
|
|
||
| this.vsync_.mutate(() => { |
There was a problem hiding this comment.
Drive-by: Allocating only one vsync task is another small performance opt.
alanorozco
commented
Mar 16, 2018
| mediaEl.setAttribute('pool-element', elId++); | ||
|
|
||
| this.vsync_.mutate(() => { | ||
| for (let i = count; i > 0; i--) { |
There was a problem hiding this comment.
Closure would compile into this faster reverse loop by default. Since i is compared against below the compiler can no longer make order guarantees so it skips the optimization.
alanorozco
commented
Mar 16, 2018
| const sources = this.getDefaultSource_(type); | ||
| mediaEl.setAttribute('pool-element', elId++); | ||
| this.enqueueMediaElementTask_(mediaEl, |
There was a problem hiding this comment.
I'm not sure if we can enqueue this task for the seed and have it also work for the cloned nodes. I didn't wanna perf-test it so I opened #14058
newmuis
approved these changes
Mar 16, 2018
alanorozco
commented
Mar 17, 2018
| * @private | ||
| */ | ||
| forEachMediaType_(callback) { | ||
| Object.keys(MediaType).forEach(callback); |
There was a problem hiding this comment.
Also just driving by 馃殫...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning nodes is faster than building them, so constructing a seed element makes sense for initialization.