Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTC docs to be much more explicit about required headers. #14077

Merged
merged 6 commits into from Mar 19, 2018
Merged

Update RTC docs to be much more explicit about required headers. #14077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4401761
Update docs
bradfrizzell Mar 16, 2018
9013eb4
whoops left in lines
bradfrizzell Mar 16, 2018
35e3e9f
Change link:
bradfrizzell Mar 16, 2018
2c353bc
Consolidate
bradfrizzell Mar 16, 2018
9058e50
Missing a header
bradfrizzell Mar 19, 2018
e174ef7
Fix doc
bradfrizzell Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions extensions/amp-a4a/rtc-documentation.md
View file
Open in desktop
Expand Up @@ -155,11 +155,7 @@ The RTC Response to a GET request must meet the following requirements:


* Status Code = 200
* Headers (in addition to automatically added headers):
* CORS
* AMP-Access-Control-Allow-Source-Origin
* Access-control-allow-origin
* Access-control-expose-header: AMP-Access-Control-Allow-Source-Origin
* See [here for Required Headers](https://github.com/ampproject/amphtml/blob/master/spec/amp-cors-requests.md#ensuring-secure-responses) and note that Access-Control-Allow-Credentials: true must be present for cookies to be included in the request.
* Body of response is a JSON object of targeting information such as:
* **<code>{"targeting": {"sport":["rugby","cricket"]}}</code>**</strong>
* The response body must be JSON, but the actual structure of that data need not match the structure here. Refer to Fast Fetch Network specific documentation for the required spec. (for example, if using DoubleClick, refer to DoubleClick docs).
Expand Down
13 changes: 4 additions & 9 deletions extensions/amp-a4a/rtc-publisher-implementation-guide.md
View file
Open in desktop
Expand Up @@ -147,17 +147,12 @@ The endpoint must use HTTPS.

The RTC Response to a GET must meet the following requirements:



* Status Code = 200
* Headers (in addition to automatically added headers):
* CORS
* AMP-Access-Control-Allow-Source-Origin
* Access-control-allow-origin
* Access-control-expose-header: AMP-Access-Control-Allow-Source-Origin
* See [here for Required Headers](https://github.com/ampproject/amphtml/blob/master/spec/amp-cors-requests.md#ensuring-secure-responses) and note that Access-Control-Allow-Credentials: true must be present for cookies to be included in the request.
* Body of response is a JSON object of targeting information such as:
* {"targeting": {"sport":["rugby","cricket"]}}
* The response body must be JSON, but the actual structure of that data need not match the structure here. Refer to Fast Fetch Network-specific documentation for the required spec. (for example, if using DoubleClick, refer to DoubleClick docs).
* **<code>{"targeting": {"sport":["rugby","cricket"]}}</code>**</strong>
* The response body must be JSON, but the actual structure of that data need not match the structure here. Refer to Fast Fetch Network specific documentation for the required spec. (for example, if using DoubleClick, refer to DoubleClick docs).



### Merging RTC Results into Ad Requests
Expand Down
12 changes: 5 additions & 7 deletions extensions/amp-ad-network-doubleclick-impl/doubleclick-rtc.md
View file
Open in desktop
Expand Up @@ -44,15 +44,13 @@ The requirements for an RTC endpoint to be used with DoubleClick are the same as

The RTC Response to a GET must meet the following requirements:

* Status Code = 200
* See [here for Required Headers](https://github.com/ampproject/amphtml/blob/master/spec/amp-cors-requests.md#ensuring-secure-responses) and note that Access-Control-Allow-Credentials: true must be present for cookies to be included in the request.
* Body of response is a JSON object of targeting information such as:
* **<code>{"targeting": {"sport":["rugby","cricket"]}}</code>**</strong>
* The response body must be JSON, but the actual structure of that data need not match the structure here. Refer to Fast Fetch Network specific documentation for the required spec. (for example, if using DoubleClick, refer to DoubleClick docs).


* Status Code = 200
* Headers (in addition to automatically added headers):
* CORS
* AMP-Access-Control-Allow-Source-Origin
* Access-control-allow-origin
* Access-control-expose-header: AMP-Access-Control-Allow-Source-Origin
* Must respond within default 1 second timeout on the response imposed by real-time-config-manager.js. Publishers may optionally shorten this timeout.

The body of the response must meet the following specification:

Expand Down