Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the bookend code to its own class. #14084

Merged
merged 3 commits into from Mar 19, 2018

Conversation

gmajoulet
Copy link
Contributor

Moving most of the bookend code to its own component.
The API is still far from being perfect but I believe this is one step in the good direction:

  • Component has to be built using bookend.build()
  • Component has to be preloaded using the asynchronous bookend.loadConfig()
  • Component can retrieve the config without being built through bookend.loadConfig(false /** applyConfig */), which is needed to get the sharing options on desktop
  • Component is toggled on/off through the store store.dispatch(TOGGLE_BOOKEND, boolean)

@newmuis newmuis merged commit 3b2269d into ampproject:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants