Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Print logs from chromedriver when visual diff tests fail #14113

Merged
merged 1 commit into from Mar 19, 2018
Merged

馃彈 Print logs from chromedriver when visual diff tests fail #14113

merged 1 commit into from Mar 19, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 19, 2018

We're trying to get to the bottom of some selenium errors while running the visual tests. They've been elusive while debugging, but appear frequently in the wild.

This PR prints the last 100 lines from chromedriver.log when failures do occur. It also cleans up an earlier fix that didn't work.

To aid in the debugging of #13700

@rsimha
Copy link
Contributor Author

rsimha commented Mar 19, 2018

/to @erwinmombay @choumx
/cc @timhaines

@timhaines
Copy link
Contributor

@rsimha Nice - please do feel welcome to email me or @me links if/when you see problems related to this.

@rsimha
Copy link
Contributor Author

rsimha commented Mar 19, 2018

Here's what the last 100 lines of chromedriver.log look like during a successful build: https://gist.github.com/rsimha/e4239983f7c3810da2a7eff69eba488e

@rsimha
Copy link
Contributor Author

rsimha commented Mar 19, 2018

Tested this locally to make sure the error message and logs get printed. This is now ready to merge.

pr-check.js: Done running gulp visual-diff --headless Total time: 1m 47s
pr-check.js: ERROR: Found errors while running gulp visual-diff --headless. Here are the last 100 lines from chromedriver.log:

<logs>

@rsimha rsimha merged commit 5c0e8bc into ampproject:master Mar 19, 2018
@rsimha rsimha deleted the 2018-03-19-ChromedriverLog branch March 19, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants