Add transition UX polish for lightbox animations #14126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
force-pushed
the
feature/transition-ctrls
branch
from
f1b17cd
to
b6d0ead
Compare
cathyxz
force-pushed
the
feature/transition-ctrls
branch
from
b6d0ead
to
3161aa1
Compare
aghassemi
approved these changes
Mar 20, 2018
| this.carousel_.setAttribute('controls', ''); | ||
|
|
||
| this.topBar_.classList.remove('fade-out'); | ||
| this.topBar_.classList.remove('hidden'); |
There was a problem hiding this comment.
this might be an existing bug, but purely using opacity to show/hide still keeps the area "tappable", worth a tests
(also normally I would say we need to also set aria-hidden when using opacity for hiding and showing, but honestly I think it is better to always have the controls readable by screen readers in this case, specially given there are only a few)
There was a problem hiding this comment.
(Merely a suggestion, haven't looked at the full diff.)
Can pointer-events: none be an alternative in this case?
There was a problem hiding this comment.
Add visibility: hidden?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably a better way to decompose some of this code though.