馃彈 AMP Header Minification: Returned theme-color through new <meta> dictionary in documentLoaded message payload. #14137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Mar 20, 2018
src/service/document-info-impl.js
Outdated
|
|
||
| let value = metaTags[name]; | ||
| if (value) { | ||
| // Change to array if more than one href for the same rel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new dictionary of tags mapping from name to content and passes this to the viewer through the documentLoaded message. This allows the viewer to access the page's theme-color to update the header's color, and can ease development of future features that also rely on tag values.