Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator updates (refactoring, English error messages) #1421

Merged
merged 2 commits into from Jan 14, 2016
Merged

Validator updates (refactoring, English error messages) #1421

merged 2 commits into from Jan 14, 2016

Conversation

powdercloud
Copy link
Contributor

This PR contains two commits.

Gregable and others added 2 commits January 13, 2016 17:10
in preparation for changing dispatch to a different mechanism.
as opposed to UPPER_CAPS_CONSTANT: some detail string.
This should improve readability of the error messages.
Internally, we still populate the detail field but this
will go away in a subsequent refactoring.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Gregable
Copy link
Member

@googlebot Confirmed

powdercloud added a commit that referenced this pull request Jan 14, 2016
Validator updates (refactoring, English error messages)
@powdercloud powdercloud merged commit 79eb156 into ampproject:master Jan 14, 2016
@powdercloud powdercloud deleted the updates branch January 14, 2016 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants