✨ amp-document-recommendations: Update local document title/history path when appending new document #14218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterjosling
commented
Mar 23, 2018
peterjosling
commented
- Updates local document.title and URL (with replaceState) when appending a new document in amp-content-recommendations. Both required for use outside of a viewer.
- Viewer integration will require changes to the viewer history API to support updating the path (currently only the hash can be changed).
peterjosling
force-pushed
the
document-recommendations-title
branch
from
2052fd5
to
9e2fe41
Compare
Passes through the return value from MultiDocManager#attachShadowDoc. Object contains the document title.
Only updates title locally, not in the viewer
Viewer history API will need updating to support updating the path in the viewer
peterjosling
force-pushed
the
document-recommendations-title
branch
from
9e2fe41
to
11a43cc
Compare
aghassemi
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.