Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy viewer files into examples.build #1422

Merged
merged 1 commit into from Jan 14, 2016

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@@ -295,6 +295,19 @@ function buildExamples(watch) {
});
}

fs.copy('examples/viewer.html',
'examples.build/viewer.html',
{clobber: true},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we factor out all this duplication?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I redid it to do a single copy for everything and all build follow on top.

@erwinmombay
Copy link
Member

LGTM

dvoytenko added a commit that referenced this pull request Jan 14, 2016
Copy viewer files into examples.build
@dvoytenko dvoytenko merged commit 0c14acc into ampproject:master Jan 14, 2016
@dvoytenko dvoytenko deleted the access18c branch January 14, 2016 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants