Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the validator build on Travis CI #1425

Merged
merged 1 commit into from Jan 14, 2016

Conversation

cramforce
Copy link
Member

This will catch build and test failures in pre/post-submit.

  • Removes assumption that there is a node.js in /usr/bin/nodejs. That is a weird ubuntuism. Instead just invokes node. I think it is reasonable that everyone has one of those in their path.
  • Creates a simple gulp task to wrap the validator build through our standard idiom.

@cramforce cramforce force-pushed the travis-validator branch 18 times, most recently from 5d55fb2 to fb85ad1 Compare January 14, 2016 04:39
@cramforce
Copy link
Member Author

CC @powdercloud @Gregable This should also make it straight forward to run integration tests between AMP and the validator at head.

@cramforce cramforce changed the title Try running the validator build on travis. Run the validator build on Travis CI Jan 14, 2016
* Simple wrapper around the python based validator build.
*/
function validator() {
execSync('cd validator && python build.py')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to cd back?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not effect parent process.

@powdercloud
Copy link
Contributor

Thank you, this makes my day. :-)

cramforce added a commit that referenced this pull request Jan 14, 2016
Run the validator build on Travis CI
@cramforce cramforce merged commit 57989f0 into ampproject:master Jan 14, 2016
@cramforce cramforce deleted the travis-validator branch January 14, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants