Revert "Make <amp-install-service-worker> a low priority element, and… #14293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove timer-based delay to installation (ampproject#13409)" This reverts commit 7a8be5f.
| // introduced to avoid installing SWs for content that the user | ||
| // only engaged with superficially. | ||
| Services.timerFor(this.win).delay(() => { | ||
| this.deferMutate(this.insertIframe_.bind(this)); |
There was a problem hiding this comment.
@jridgewell removed deferMutate, make sure you merge the changes from here into this revert: c4ef869#diff-d7bcc789dc4ca07564072200b4451bb3
| expect(iframe.getAttribute('sandbox')).to.equal( | ||
| 'allow-same-origin allow-scripts'); | ||
| let deferredMutate; | ||
| implementation.deferMutate = fn => { |
There was a problem hiding this comment.
Same as above: c4ef869#diff-c7e92f692652c6ad5db6167bf7608b8e
There was a problem hiding this comment.
Also, you can move anything relating to LayoutPriority because it's no longer part of this extension
danielrozenberg
approved these changes
Mar 28, 2018
added 2 commits
March 28, 2018 17:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… remove timer-based delay to installation (#13409)"
This reverts commit 7a8be5f.
Fixes #14288 and reopens #12473.