Shadow dom Hint layer. #14314
Merged
Shadow dom Hint layer. #14314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmajoulet
commented
Mar 29, 2018
gmajoulet
commented
- Rendering the hint layer in a shadow DOM
- Only rendering the hint layer when needed
- No op if desktop
gmajoulet
force-pushed
the
shadow_dom_hint
branch
from
e6cac91
to
5d4897b
Compare
newmuis
approved these changes
Mar 30, 2018
| */ | ||
| constructor(win) { | ||
| constructor(win, storyElement) { |
There was a problem hiding this comment.
nit: prefer something like parentElement or containerElement to imply that this implementation does not particularly care that the element passed is a story
There was a problem hiding this comment.
Replaced here and in bookend.js
gmajoulet
force-pushed
the
shadow_dom_hint
branch
from
3bf532c
to
4d366e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.