♿ Adds Alt & aria-label to Placeholder Images #14391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
approved these changes
Apr 3, 2018
| placeholder.setAttribute('layout', 'fill'); | ||
| placeholder.setAttribute('placeholder', ''); | ||
| placeholder.setAttribute('referrerpolicy', 'origin'); | ||
| placeholder.setAttribute('alt', 'loading video'); |
There was a problem hiding this comment.
This line is duplicated below under the else block. You can remove it.
|
well spotted - have removed that line |
|
@gulliverhan could you merge master onto this branch to incorporate the most recent test fixes? This will make CI more reliable and likely to pass. Sorry about that. |
|
Thank you! |
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
* adds alt & aria label to brid-player & tests * adds alt & aria-label to amp-jwplayer & tests to cover * adds alt & aria-label to amp-kaltura-player & tests * adds alt & aria-label to placeholder img for amp-springboard-player * adds alt & aria-label attributes to img placeholder for amp-youtube * fixes lint errors * removes duplicated line
This was referenced Mar 31, 2021
This was referenced Apr 12, 2021
This was referenced Apr 27, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses Issue #5508
Adds alt tag & propagates aria label to the placeholder images for
amp-brid-player
amp-jwplayer
amp-kaltura-player
amp-springboard-player
amp-youtube