Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories XHR request service. #14393

Merged
merged 4 commits into from Apr 4, 2018
Merged

Conversation

gmajoulet
Copy link
Contributor

To continue our effort on components isolation, each component needs to be able to fetch its own resources.

This PR introduces:

  • New service to send XHR requests, accessible by any component
  • Unit tests
  • Actually using this new service to fetch the bookend config, and sharing providers config
  • Using inheritance for the share widgets (could have done this one in a separate PR though)

Needed for #12186

/** @private @const {!../../../src/service/xhr-impl.Xhr} */
this.xhr_ = Services.xhrFor(win);

/** @type {function():(!Promise<!JsonObject>|!Promise<null>)} */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@const

@gmajoulet gmajoulet merged commit ecf2ac3 into ampproject:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants