amp-consent: disable multi consent with flag #14478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
approved these changes
Apr 6, 2018
|
|
||
| if (!this.isSupportMulti_) { | ||
| // Assert single consent instance | ||
| user().assert(Object.keys(consents).length <= 1, |
There was a problem hiding this comment.
I thought we we just going to honor the first one? Not break?
There was a problem hiding this comment.
Right that was the plan. But then I realized it is always safer to throw error. For example, it is always better to throw error if someone ask for three consents to unblock content, rather than unblock content without dealing with the other two.
| @@ -90,6 +92,9 @@ export class AmpConsent extends AMP.BaseElement { | |||
|
|
|||
| /** @private {!Object<string, boolean>} */ | |||
| this.consentUIPendingMap_ = map(); | |||
|
|
|||
| /** @private {boolean} */ | |||
| this.isSupportMulti_ = false; | |||
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
* multi-consent flag * address comment, move const out src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #13716
Added 'multi-consent' flag to only support single consent instance with v0.