Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Fix next / prev control colors on lightbox #14493

Merged
merged 1 commit into from Apr 9, 2018

Conversation

cathyxz
Copy link
Contributor

@cathyxz cathyxz commented Apr 9, 2018

The current implementation doesn't work. Use background-image for Edge compatibility for now. If we ever want to vary the icon colors, we should change the svg fill back to currentColor and change the background color.

Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathyxz cathyxz merged commit 592c6b9 into ampproject:master Apr 9, 2018
@cathyxz cathyxz deleted the bugfix/lightbox-ctrl-color branch April 9, 2018 22:15
glevitzky pushed a commit that referenced this pull request Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants