Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 amp-consent prompt UI race condition fix #14550

Merged
merged 1 commit into from Apr 11, 2018
Merged

馃悰 amp-consent prompt UI race condition fix #14550

merged 1 commit into from Apr 11, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Apr 11, 2018

No description provided.

@zhouyx zhouyx requested a review from calebcordry April 11, 2018 16:54
calebcordry
calebcordry approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change vsync to baseElement.mutateElement() in separate PR.

@zhouyx zhouyx force-pushed the amp-consent-race-condition-fix branch from 4046335 to e2a91c0 Compare April 11, 2018 17:47
@zhouyx zhouyx merged commit 1d73dc5 into ampproject:master Apr 11, 2018
glevitzky pushed a commit that referenced this pull request Apr 27, 2018
@zhouyx @glevitzky
fix (#14550)
5d66adf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhouyx @calebcordry @googlebot