Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use hasOwnProperty in simple-template checks instead of dot access #14607

Merged
merged 3 commits into from Apr 16, 2018
Merged

🐛 Use hasOwnProperty in simple-template checks instead of dot access #14607

merged 3 commits into from Apr 16, 2018

Conversation

newmuis
Copy link
Contributor

@newmuis newmuis commented Apr 13, 2018

Fixes #14388

@newmuis newmuis requested a review from alanorozco April 13, 2018 04:13
@newmuis newmuis force-pushed the amp-story-simple-templates-hasown branch from 50e294a to 55f85de Compare April 14, 2018 00:33
@newmuis newmuis force-pushed the amp-story-simple-templates-hasown branch from 55f85de to 92860b4 Compare April 16, 2018 13:50
alanorozco
alanorozco approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hasOwn from src/utils/object.js

@newmuis newmuis merged commit 720970b into ampproject:master Apr 16, 2018
glevitzky pushed a commit that referenced this pull request Apr 27, 2018
@newmuis @glevitzky
🐛 Use hasOwnProperty in simple-template checks instead of dot access (#…
750604c 
…14607)

* Use hasOwnProperty in simple-template checks instead of dot access

* Fix types

* Use hasOwn fromo object.js instead of native hasOwnProperty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@newmuis @alanorozco @googlebot