✨ amp-next-page: Rewrite URLs to fetch from the cache when serving from the cache #14633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterjosling
commented
Apr 16, 2018
peterjosling
commented
- Allows for publishers to serve the same set of URLs for both canonical/cache
- Avoids making cross-origin requests from the cache, and ensures that the requested document is valid
peterjosling
force-pushed
the
document-recommendations-cache-url
branch
from
6d79525
to
3fe3abd
Compare
aghassemi
approved these changes
Apr 16, 2018
aghassemi
suggested changes
Apr 16, 2018
|
|
||
| if (isProxyOrigin(url)) { | ||
| const sourceOrigin = getSourceOrigin(url); | ||
| configJson.pages.forEach(rec => { |
There was a problem hiding this comment.
should become configJson['pages'] and handle the edge case where it may be null or not be an array. @peterjosling
There was a problem hiding this comment.
Oops, should've been this.config_.pages.
null/isArray checks already done in assertConfig.
peterjosling
force-pushed
the
document-recommendations-cache-url
branch
from
3fe3abd
to
76393fd
Compare
- Allows for publishers to serve the same set of URLs for both canonical/cache - Avoids making cross-origin requests from the cache, and ensures that the requested document is valid
peterjosling
force-pushed
the
document-recommendations-cache-url
branch
from
76393fd
to
b851504
Compare
aghassemi
approved these changes
Apr 17, 2018
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Apr 17, 2018
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.