Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Switch to correct parameter name for detecting CCT #14652

Merged
merged 3 commits into from Apr 17, 2018

Conversation

brandondiamond
Copy link
Contributor

@brandondiamond brandondiamond commented Apr 16, 2018

Unfortunately, an incorrect parameter name is being checked to determine whether code is running within CCT.

This updates the parameter's name.

@dreamofabear dreamofabear merged commit a4f3bd6 into ampproject:master Apr 17, 2018
@dreamofabear dreamofabear deleted the agsa branch April 17, 2018 00:24
erwinmombay pushed a commit that referenced this pull request Apr 17, 2018
* Switch to correct parameter name.

* Updating tests
erwinmombay pushed a commit that referenced this pull request Apr 17, 2018
* Switch to correct parameter name.

* Updating tests
erwinmombay pushed a commit that referenced this pull request Apr 17, 2018
* Switch to correct parameter name.

* Updating tests
jridgewell pushed a commit to jridgewell/amphtml that referenced this pull request Apr 17, 2018
* Switch to correct parameter name.

* Updating tests
glevitzky pushed a commit that referenced this pull request Apr 27, 2018
* Switch to correct parameter name.

* Updating tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants