-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Switch from VMs to Container-based images on Travis (don't use sudo
) (Redux)
#15071
Conversation
/to @taymonbeal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the slowdown last time we tried this attributed to the time it took to copy Chrome into userspace? That surprises me, since it should have been just copying some files from the build cache.
I suppose it's worth a try if we're not sure.
@taymonbeal We reverted because the build and test steps slowed down greatly on container-based images, not because Chrome took longer to install. I remembered this because we now use Travis' pre-installed Chrome, and figured it was worth another try since our builds and tests have changed significantly since last year. |
Ah, so you think it might be faster this time for reasons unrelated to Chrome? Sure, let's find out. |
Seems like slow performance on Travis docker images is a common problem. I wonder if one of those issues contains a solution. Let's see once we have results. |
Turns out that headless chrome isn't starting on container based images: https://travis-ci.org/ampproject/amphtml/jobs/374642940#L1237 Trying the suggestions in https://docs.travis-ci.com/user/chrome |
Unfortunately, this is still slowing down Unless someone knows how to speed things up on docker images, this is probably a dead end. |
Found a typo in the previous fix. Trying again... |
Karma errors are fixed, but chrome is still crashing when run under Capybara / Ruby. I've logged travis-ci/travis-ci#9568 to investigate. |
/cc @timhaines in case you've encountered problems with Travis container images and know of a workaround to item 2 in travis-ci/travis-ci#9568 |
ping @rsimha, please merge or close. Thanks. |
Can't do either until the blocking issue is resolved. |
This now works, but builds are slower, so it's not worth it. Closing PR. |
This was explored last year in #9651, but we had to revert because builds and tests took longer on Container-based images.
Now that we no longer install Chrome, but use the
chrome
addon on Travis, and now that our builds and tests have significantly changed since last year, let's try once again and see how things go this time.