Force set amp-lightbox-gallery buttons to content-box sizing #15080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
reviewed
May 4, 2018
There was a problem hiding this comment.
Our build has an svg optimizer pass, and it does this conversion automatically:
// build/amp-lightbox-gallery-0.1.css.js
export const CSS = "/*...*/url(\"data:image/svg+xml;charset=utf-8,%3Csvg viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath d='M18.295 5.705a.997.997 0 0 0-1.41 0L12 10.59 7.115 5.705a.997.997 0 1 0-1.41 1.41L10.59 12l-4.885 4.885a.997.997 0 0 0 1.41 1.41L12 13.41l4.885 4.885a.997.997 0 0 0 1.41-1.41L13.41 12l4.885-4.885a.997.997 0 0 0 0-1.41z' fill='%23fff' fill-rule='nonzero'/%3E%3C/svg%3E\"/*...*/";
…parsing" This reverts commit ade746c.
cathyxz
changed the title
cathyxz
changed the title
cvializ
approved these changes
May 4, 2018
aghassemi
reviewed
May 4, 2018
| @@ -87,6 +87,7 @@ amp-lightbox-gallery .amp-carousel-button { | |||
| width: 24px; | |||
| height: 24px; | |||
| padding: 16px; | |||
| box-sizing: content-box; | |||
There was a problem hiding this comment.
put !important ? to protect when we actually make this public in future
There was a problem hiding this comment.
I wasn't sure about this, since the intention here is to allow them to edit the dimensions of the button. There seemed to be an argument to allow them to style this however they please.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
May 10, 2018
…ect#15080) * Replace double quotes with single quotes for firefox windows parsing * Set box sizing to content box * Revert "Replace double quotes with single quotes for firefox windows parsing" This reverts commit ade746c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force buttons to be
content-size, since sometimes people will doAs a pattern.