Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 More error checking, fix doc links #15109

Merged
merged 2 commits into from May 5, 2018
Merged

🏗 More error checking, fix doc links #15109

merged 2 commits into from May 5, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 5, 2018

This PR:

  1. Adds some error checking to build-system/check-package-manager.js, since it's run very often, and shouldn't ever fail.
  2. Fixes some incorrect / missing links in the docs.

Follow up to #15092

@rsimha rsimha self-assigned this May 5, 2018
@rsimha rsimha requested a review from jridgewell May 5, 2018 00:27
@rsimha
Copy link
Contributor Author

rsimha commented May 5, 2018

/to @jridgewell

@rsimha rsimha changed the title 🏗 Error check the detection of version numbers of node, gulp, and yarn 🏗 More error checking, fix doc links May 5, 2018
@rsimha rsimha requested review from cathyxz and aghassemi May 5, 2018 00:39
@rsimha
Copy link
Contributor Author

rsimha commented May 5, 2018

/to @cathyxz @aghassemi as backup reviewers.

@rsimha rsimha merged commit ec5fde6 into ampproject:master May 5, 2018
@rsimha rsimha deleted the 2018-05-04-GulpCheck branch May 5, 2018 02:12
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants