Subscriptions: fixing examples #15129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prateekbh
commented
May 7, 2018
prateekbh
commented
- Fix amp example
- Whitelist subscription attributes
- Execute action from amp-subscriptions-google
dvoytenko
suggested changes
May 7, 2018
| subscriptions-action="login" | ||
| subscriptions-service="subscribe.google.com" | ||
| subscriptions-decorate>Login</div> | ||
| <div subscriptions-action="login" subscriptions-display="NOT loggedIn">Login</div> |
There was a problem hiding this comment.
NOT loggedIn is now wrong too, right? Shouldn't it be NOT data.loggedIn?
| @@ -339,6 +334,10 @@ <h1 itemprop="headline">Lorem Ipsum</h1> | |||
| </template> | |||
| <template type="amp-mustache" subscriptions-dialog subscriptions-display="NOT loggedIn"> | |||
| <div>Dialog for non logged in users<div> | |||
| <div subscriptions-display="NOT loggedIn" | |||
| @@ -131,6 +131,8 @@ const WHITELISTED_ATTRS = [ | |||
| 'subscriptions-actions', | |||
| 'subscriptions-section', | |||
| 'subscriptions-display', | |||
| 'subscriptions-service', | |||
| 'subscriptions-decorate', | |||
There was a problem hiding this comment.
Did you already put subscrpitions-decorate into validator?
dvoytenko
approved these changes
May 8, 2018
examples/amp-subscriptions.amp.html
Outdated
| subscriptions-action="subscribe" | ||
| subscriptions-service="subscribe.google.com" | ||
| subscriptions-decorate>Login</div> | ||
| <div subscriptions-display="NOT grantReason">btw u are not subscribed</div> |
There was a problem hiding this comment.
Let's do grantReason != "SUBSCRIBED" (SUBSCRIBER, whichever is the latest on this.)
There was a problem hiding this comment.
reverted this and loggedIn change as that stuff is in PR #15059
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
May 10, 2018
* fixing examples * fixing types * fixing types * adding in validatior * reverting data changes in example
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.