Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Change Parsely's default incremental engaged time heartbeat interval #15135

Conversation

cwisecarver
Copy link
Contributor

@cwisecarver cwisecarver commented May 7, 2018

This changes the Parsely default incremental engaged time heartbeat interval to 10 seconds.

@cwisecarver cwisecarver changed the title ✨ Add Parsely heartbeat to default config ✨ Change Parsely's default incremental engaged time heartbeat interval May 15, 2018
@cwisecarver
Copy link
Contributor Author

@lannka This just changed the default heartbeat interval from 5 to 10 seconds. I would appreciate if we could get this merged before the next release if possible.

@lannka lannka merged commit 54479d2 into ampproject:master May 15, 2018
@lannka lannka added this to TODO in 3P Ads & Analytics Support via automation May 15, 2018
@lannka lannka self-assigned this May 15, 2018
@lannka
Copy link
Contributor

lannka commented May 15, 2018

Sorry for the delay. It will go into today's canary build, and hit prod next Tuesday.

@cwisecarver
Copy link
Contributor Author

No worries @lannka. Thanks for getting in!

@cwisecarver cwisecarver deleted the feature/add-parsely-heartbeat-to-default-config branch May 16, 2018 20:47
@lannka lannka moved this from TODO to In Review in 3P Ads & Analytics Support May 17, 2018
@lannka lannka moved this from In Review to Done in 3P Ads & Analytics Support May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants