Fix carousel duplicate thumbnail bug #15141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
reviewed
May 8, 2018
| @@ -188,6 +188,10 @@ export class LightboxManager { | |||
| && slide.getAttribute('lightbox') !== lightboxGroupId); | |||
| if (!shouldExcludeSlide) { | |||
| slide.setAttribute('lightbox', lightboxGroupId); | |||
| if (this.seen_.includes(slide)) { | |||
There was a problem hiding this comment.
Do you still need to set the attribute if the slide is in this.seen_? Or will it already be set?
There was a problem hiding this comment.
That's true. Yes, it will have already been set if it's in seen.
alanorozco
approved these changes
May 8, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
May 10, 2018
* Fix carousel duplicate thumbnail bug * Reorder set lightbox and check if seen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where lightbox manager processes carousels by adding lightbox group ids to the carousel. However, we rescan lightboxes on DOM update, so carousel contents are scanned twice, resulting in duplicate thumbnails.
Part of QA-ing lightbox with AliExpress.
Closes #15139.