✨ amp-next-page: Allow hiding of arbitrary elements in child pages #15150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjosling
force-pushed
the
next-page/element-hiding
branch
3 times, most recently
from
04d51e8
to
9e3af68
Compare
- Reads from hideSelectors key in config - Blacklists i-amphtml-* selectors, like the validator - Runs querySelectorAll() for all the selectors when the shadow document is attached. Generating and injecting CSS would presumably be more efficient but would need more validation/sanitisation on the selectors. AFAIK passing user input directly to `querySelectorAll` should be safe.
peterjosling
force-pushed
the
next-page/element-hiding
branch
from
9e3af68
to
cc6fc3b
Compare
aghassemi
approved these changes
May 10, 2018
| function assertSelectors(selectors) { | ||
| selectors.forEach(selector => { | ||
| BANNED_SELECTOR_PATTERNS.forEach(pattern => { | ||
| user().assert(typeof selector === 'string', |
There was a problem hiding this comment.
Done, and updated other usages.
rsimha
reviewed
May 11, 2018
| win.dispatchEvent(new Event('scroll')); | ||
| yield macroTask(); | ||
|
|
||
| const shadowDoc = attachShadowDocSpy.firstCall.returnValue.ampdoc; |
There was a problem hiding this comment.
@aghassemi @peterjosling This test is causing widespread unit test failures on master today: https://travis-ci.org/ampproject/amphtml/jobs/377848593#L2008
Can you fix this test, or skip if the fix isn't obvious?
There was a problem hiding this comment.
Also see this repeated failure from the same set of tests:
https://travis-ci.org/ampproject/amphtml/jobs/377819689#L1977
https://travis-ci.org/ampproject/amphtml/jobs/377835829#L1977
https://travis-ci.org/ampproject/amphtml/jobs/377850058#L1977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary use case is hiding repeated page headers/footers.
querySelectorAllshould be safe.