Amp ad exit vendor dependency #15208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
approved these changes
May 11, 2018
jonkeller
reviewed
May 11, 2018
| @@ -26,7 +26,7 @@ Before you can add your analytics service to AMP HTML runtime, you may need to: | |||
| 1. ```"vars": {}``` for additional default variables. | |||
| 1. ```"requests": {}``` for requests that your service will use. | |||
| 1. ```"optout":``` if needed. We currently don't have a great opt-out system, so please reach out to help us design one that works well for you. | |||
| 1. If you are using iframe transport, add a new block to ANALYTICS_IFRAME_TRANSPORT_CONFIG in vendors.js containing ```"transport": { "iframe": *url* }``` | |||
| 1. If you are using iframe transport, add a new block to ANALYTICS_IFRAME_TRANSPORT_CONFIG in iframe-transport-vendors.js containing ```"transport": { "iframe": *url* }``` | |||
There was a problem hiding this comment.
Change link on line 35 to:
https://github.com/ampproject/docs/blob/master/content/docs/analytics/analytics-vendors.md
(change ads_analytics to just analytics)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-ad-exit has dependency on amp-analytics iframe transport iframes but is unintentionally pulling in the entire amp-analytics vendor config. Moving transport config to separate file corrected this inadvertent include reducing file size from ~50k to 12k.