Skip flaky amp-next-page tests #15232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
May 11, 2018
rsimha
reviewed
May 11, 2018
| @@ -97,7 +97,9 @@ env => { | |||
| toggleExperiment(win, 'amp-next-page', false); | |||
| }); | |||
|
|
|||
| it('does not fetch the next document before 3 viewports away', function* () { | |||
| // This test is flaky on Headless Chrome on Travis because it does | |||
| // call fetchDocument. | |||
There was a problem hiding this comment.
Add a TODO with the issue number.
rsimha
reviewed
May 11, 2018
| @@ -97,7 +97,9 @@ env => { | |||
| toggleExperiment(win, 'amp-next-page', false); | |||
| }); | |||
|
|
|||
| it('does not fetch the next document before 3 viewports away', function* () { | |||
| // TODO (#15234): This test is flaky on Headless Chrome on Travis because it does | |||
There was a problem hiding this comment.
The format is TODO(@someone, #xxxxx): Comment goes here
|
/cc @peterjosling let's fix and enable this test later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does not fetch the next document before 3 viewports awayadds the hidden class to hideSelector elements