馃悰amp-consent scheduleLayout for prompt UI elements #15281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
May 15, 2018
| @@ -553,6 +559,7 @@ export class AmpConsent extends AMP.BaseElement { | |||
| this.getViewport().addToFixedLayer(this.element); | |||
| setImportantStyles(dev().assertElement(this.postPromptUI_), | |||
| {display: 'block'}); | |||
| this.scheduleLayout(this.postPromptUI_); | |||
| {display: 'block'}); | ||
| const uiElement = this.consentUI_[this.currentDisplayInstance_]; | ||
| setImportantStyles(uiElement, {display: 'block'}); | ||
| this.scheduleLayout(uiElement); |
There was a problem hiding this comment.
document this is for amp-iframe which will be unlaid out on close.
| @@ -131,6 +131,11 @@ export class AmpConsent extends AMP.BaseElement { | |||
| // TODO: Decide what to do with incorrect configuration. | |||
| this.assertAndParseConfig_(); | |||
|
|
|||
| const children = this.getRealChildren(); | |||
There was a problem hiding this comment.
document this is for amp-iframe which will be unlaid out on close.
zhouyx
force-pushed
the
amp-consent-scheduleLayout
branch
from
0332de5
to
9ae021b
Compare
erwinmombay
pushed a commit
that referenced
this pull request
May 15, 2018
* schedueLayout * add comment * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally runtime will handle the layout of prompt element. But currently element won't be laid out on fixed layer update.
<amp-consent>need to take ownership of its children's layout.