Introduce consentHandlingOverride for amp-ad
#15285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
suggested changes
May 15, 2018
| @@ -160,6 +161,7 @@ export const adConfig = { | |||
| remoteHTMLDisabled: true, | |||
| masterFrameAccessibleType: 'google_network', | |||
| fullWidthHeightRatio: 1.2, | |||
| consentHandlingOverride: true, | |||
There was a problem hiding this comment.
We also need to document this here. https://github.com/ampproject/amphtml/blob/master/ads/_config.js#L56
There was a problem hiding this comment.
need documentation here : )
zhouyx
reviewed
May 15, 2018
3p/3p.js
Outdated
| @@ -272,6 +272,7 @@ function validateAllowedFields(data, allowedFields) { | |||
| location: true, | |||
| mode: true, | |||
| consentNotificationId: true, | |||
| consentHandlingOverride: true, | |||
There was a problem hiding this comment.
this should be blockOnConsent, the attribute is data-block-on-consent
There was a problem hiding this comment.
I couldn't see the name change : )
There was a problem hiding this comment.
woops. really done now. thanks!
| @@ -160,6 +161,7 @@ export const adConfig = { | |||
| remoteHTMLDisabled: true, | |||
| masterFrameAccessibleType: 'google_network', | |||
| fullWidthHeightRatio: 1.2, | |||
| consentHandlingOverride: true, | |||
There was a problem hiding this comment.
need documentation here : )
zhouyx
approved these changes
May 15, 2018
erwinmombay
pushed a commit
that referenced
this pull request
May 15, 2018
* Introduce `consentHandlingOverride` for amp-ad * Introduce `consentHandlingOverride` for amp-ad * address comments * address comments * Fix presubmit * Extra lint fixes. * woops * Fix type-checks. * Fix type-checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15269