New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Use eslint-plugin-jsdoc
instead of the built in valid-jsdoc
#15294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
After:
|
alanorozco
approved these changes
May 15, 2018
This was referenced May 15, 2018
Before:
After:
|
jridgewell
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
valid-jsdoc
rule built in toeslint
(we started using it in #15256) has a few problems:This PR does the following:
eslint-plugin-jsdoc
, which is more sophisticated than the built invalid-jsdoc
. See https://github.com/gajus/eslint-plugin-jsdoceslint
was being executed on an empty glob when there are no.js
files in the PR / commit being tested.Fixes #15293
Fixes #15295
Fixes #15296
Partial fix for #15255
Follow up to #15256