✅✨ Allow <amp-video noaudio> #15322
Merged
✅✨ Allow <amp-video noaudio> #15322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
May 15, 2018
| @@ -60,6 +60,10 @@ attr_lists: { | |||
| name: "muted" | |||
| value: "" | |||
| } | |||
| attrs: { | |||
| name: "noaudio" | |||
There was a problem hiding this comment.
Please also add to .md file describing its purpose.
honeybadgerdontcare
approved these changes
May 15, 2018
|
@alanorozco is documentation coming in a different PR or an issue requesting it? |
|
@aghassemi @honeybadgerdontcare Documentation added. |
aghassemi
approved these changes
May 15, 2018
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
May 16, 2018
Merged
honeybadgerdontcare
pushed a commit
that referenced
this pull request
May 16, 2018
* Attributes must be alphabetical by name * Error message for inline style being too long. * Revision bump for #15322
|
/slowpoke Should |
|
@newmuis: @aghassemi and I decided against that. If the semantics for |
|
Not really required, just bikeshedding on the semantics of having a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merely an annotation for:
<amp-story>to implement its own UI semantics for mute/unmutePartial for #13652
Fixes #11940
/cc @newmuis