Change consent policy state enum

[zhouyx]

Learned my lesson: not to use 0 for enum value. Try to fix this before it's too late : )

[lannka]

please document this enum will have external dependency, we should never change values anymore (after this PR).

[zhouyx]

done.

[zhouyx]

the amp-ad-0.1.js size didn't increase after the change. we are good with importing CONSENT_POLICY_STATE

[zhouyx]

Not sure about why type check fails.
is there any recent change to type check? @rsimha could you help me with this.

[rsimha]

@zhouyx No recent changes to type check, so far as I know.

1. Is the path accurate?
2. Are the types being exported properly from the source file?
3. Are the type names being imported properly in the file that's reporting the Type check errors?

[zhouyx]

Thanks @rsimha
I think I know why check type is failing. 3p/adsense.js imports from consent-state.js, which imports Services from './services.js.
I should separate the enum value to a different file to fix this.

[zhouyx]

@lannka The change is indeed risky. Almost forget the ima-video 😨

[zhouyx]

@choumx @jridgewell could you help with the v0.js size? I don't think the change will add size to it.

[jridgewell]

Try to fix this before it's too late

What’s the bug? There’s nothing inherently wrong with using zero, as long as all checks are ===.

could you help with the v0.js size

Just bump the size.

[zhouyx]

It's not a bug now, but error prone. As you mention as long as all checks are ===. Since this an enum exposing to 3P code, we probably want to avoid that.

Cool! I'll bump the size!

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

CLAs look good, thanks!

[rsimha]

Percy diff seems to be from a new video test that's failing. @aghassemi

[aghassemi]

@rsimha Looks like the video "controls" get hidden based on a timer and depending on when Percy takes a screenshot, it can flake. #15479 to fix it. For now we can approve the existing screenshots to make this PR green.