🏗 During PR checks, first run the tests changed by the PR (if any) #15461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During PR checks, we run about 8000 unit tests. This typically leads to a long wait to see results from the unit tests that were added / modified by the PR.
In this PR, we add a call to
gulp test --local-changesbefore the call togulp test --unit, so that we can fail early if a bad unit test is checked in. Note thatgulp test --local-changeswill fail (instead of just warning) if the unit tests contain unhandledconsole.errors, and provide early feedback that they must be fixed.Coming up: Add this to a pre-push hook so that developers don't need to wait for Travis builds.
Partial fix for #15369