馃悰 amp-next-page: adding common attrs for script tag to validation rules #15477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeybadgerdontcare
approved these changes
May 22, 2018
twifkak
pushed a commit
to twifkak/amphtml
that referenced
this pull request
May 23, 2018
Merged
twifkak
pushed a commit
to twifkak/amphtml
that referenced
this pull request
May 23, 2018
honeybadgerdontcare
pushed a commit
that referenced
this pull request
May 23, 2018
* Skip non-feature tests when running with --update_tests. * Revision bump for #15446 * Revision bump for #15477 * Revision bump for #15474 * Revision bump for #15471 * Modify validator_test so that it can create files with --update_test. * Split validator_test to two test files * Fix eslint errors in validator{,_rules}_test.js. * Fix presubmit errors in validator_test.js. * Remove unwanted console.log statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @bpaduch for finding the bug.