Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Update documentation for amp-consent integration in ad #15493

Merged
merged 3 commits into from May 23, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented May 22, 2018

No description provided.

@lannka lannka requested review from jasti and zhouyx May 22, 2018 17:12
`window.context` APIs.
In that case, the `amp-ad` element will be blocked from loading until the consent accepted.
Individual ad network can override this default consent handling by putting a `consentHandlingOverride: true` in `ads/_config.js`.
Doing so will unblock the ad loading once the consent is responded. It will be then the ad network's responsibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be correct after we add predefined consent policy : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. We'll amend this once that feature is turned on.

@lannka lannka merged commit 2511506 into ampproject:master May 23, 2018
@lannka lannka deleted the ad-consent-md branch May 23, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants