Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator: make gulp validator --update_tests work #15494

Merged
merged 1 commit into from May 22, 2018
Merged

validator: make gulp validator --update_tests work #15494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions build-system/tasks/validator.js
View file
Open in desktop
Expand Up @@ -15,22 +15,27 @@
*/
'use strict';

const argv = require('minimist')(process.argv.slice(2));
const gulp = require('gulp-help')(require('gulp'));
const {execOrDie} = require('../exec');

let validatorArgs = '';
if (argv.update_tests) {
validatorArgs += ' --update_tests';
}

/**
* Simple wrapper around the python based validator build.
*/
function validator() {
execOrDie('cd validator && python build.py');
execOrDie('cd validator && python build.py' + validatorArgs);
}

/**
* Simple wrapper around the python based validator webui build.
*/
function validatorWebui() {
execOrDie('cd validator/webui && python build.py');
execOrDie('cd validator/webui && python build.py' + validatorArgs);
}

gulp.task('validator', 'Builds and tests the AMP validator.', validator);
Expand Down