Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate data-order-by attribute in <amp-facebook-comments> #15508

Merged
merged 2 commits into from May 23, 2018
Merged

Propagate data-order-by attribute in <amp-facebook-comments> #15508

merged 2 commits into from May 23, 2018

Conversation

nainar
Copy link
Contributor

@nainar nainar commented May 23, 2018

Without this PR the data-order-by attribute being set on <amp-facebook-comments> does nothing.

@nainar nainar requested a review from cvializ May 23, 2018 01:03
cvializ
cvializ approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@nainar nainar merged commit b62a235 into ampproject:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvializ cvializ cvializ approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nainar @cvializ @googlebot