Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change enum value round 2 (do not use zero) #15580

Merged
merged 3 commits into from May 25, 2018
Merged

Change enum value round 2 (do not use zero) #15580

merged 3 commits into from May 25, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 24, 2018

Second round of changing enum

@zhouyx zhouyx requested a review from lannka May 24, 2018 23:35
lannka
lannka approved these changes May 25, 2018
View reviewed changes
extensions/amp-consent/0.1/consent-state-manager.js Outdated
@@ -26,11 +26,11 @@ const TAG = 'CONSENT-STATE-MANAGER';
* @enum {number}
*/
export const CONSENT_ITEM_STATE = {
UNKNOWN: 0,
GRANTED: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACCEPTED

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zhouyx zhouyx merged commit 3504480 into ampproject:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhouyx @lannka @googlebot