Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Don't fail tests with console.errors during gulp test --local-changes if there are too many of them #15607

Merged
merged 1 commit into from May 25, 2018
Merged

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 25, 2018

With #15585, we started running tests related to a source file change during gulp test --local-changes. This is causing trouble on Travis when lots of tests end up being run for a given source file change.

See https://travis-ci.org/ampproject/amphtml/jobs/383837321

In this PR, we no longer fail tests with errors when more than a certain number of tests are run.

Follow up to #15585

@rsimha rsimha self-assigned this May 25, 2018
@rsimha rsimha requested a review from jridgewell May 25, 2018 21:06
@rsimha
Copy link
Contributor Author

rsimha commented May 25, 2018

@jridgewell This should unblock #15414

@rsimha rsimha merged commit 054bb95 into ampproject:master May 25, 2018
@rsimha rsimha deleted the 2018-05-25-FailLocalChanges branch May 25, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants