Enable logging with verbose flag #15657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
reviewed
May 30, 2018
build-system/tasks/karma.conf.js
Outdated
| @@ -208,6 +208,7 @@ module.exports = { | |||
| failOnConsoleError: !process.env.TRAVIS && !process.env.LOCAL_PR_CHECK, | |||
| // TODO(rsimha, #14432): Set to false after all tests are fixed. | |||
| captureConsole: true, | |||
| debugConsole: false, | |||
There was a problem hiding this comment.
Let's call this verboseLogging, since it's triggered by the --verbose flag.
test/_init_tests.js
Outdated
| const {debugConsole} = window.__karma__.config; | ||
| if (debugConsole) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Adding the logic here will result in consoleInfoLogWarnSandbox unnecessarily being created. You could move this to where stubConsoleInfoLogWarn() is called in beforeEach().
Lines 376 to 384 in cbf3929
|
/cc @calebcordry |
rsimha
reviewed
Jun 4, 2018
| const {verboseLogging} = window.__karma__.config; | ||
| if (!verboseLogging) { | ||
| stubConsoleInfoLogWarn(); | ||
| } |
There was a problem hiding this comment.
Seems like we're no longer creating the sandbox when --verbose is used, resulting in the following error:
TypeError: Cannot read property 'restore' of undefined
at restoreConsoleInfoLogWarn (/tmp/test/_init_tests.js:373:28 <- /tmp/20fafa07a5f318252b366d0a8daf1740.browserify:72980:29)
at Context.<anonymous> (/tmp/test/_init_tests.js:410:2 <- /tmp/20fafa07a5f318252b366d0a8daf1740.browserify:73018:3)
There was a problem hiding this comment.
To fix, we'd need to include this change too:
// Used to restore info, log, and warn level logging after each test.
function restoreConsoleInfoLogWarn() {
if (consoleInfoLogWarnSandbox) {
consoleInfoLogWarnSandbox.restore();
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logging to terminal feature as well as enables logging to the browser console.
I believe the documentation for -verbose is sufficient already.
Adding
-verbosecould lead to failure to throw test errors if there'sconsole.log/warn/infoinvolved, but I think that's really minor.I am also open to create a
-debugflag and separate the log to terminal vs log to console feature.