🐛Fix date picker hanging when manually editing year #15668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
May 30, 2018
cathyxz
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date picker currently hangs if you chang the date in the text box from "05/05/2018" to "05/05/201". This PR resolves that issue by preventing the widget from attempting to render thousands of dates in the past. Once the root cause for the poor perfomance is found, this restriction can be lifted. I expect this will improve the experience for the vast majority of use-cases, while negatively impacting very few.
The user may still manually click month after month to select a date in the distant past beyond 1900, or may type a date in the distant past beyond 1900. If the user types the date beyond 1900 they will not see it reflected in the picker.