Doubleclick remove fast fetch upgrade predicate #15804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
approved these changes
Jun 5, 2018
| @@ -638,7 +638,7 @@ describe('amp-a4a', () => { | |||
| describe('illegal render mode value', () => { | |||
| let devErrLogSpy; | |||
| beforeEach(() => { | |||
| devErrLogSpy = sandbox.spy(dev(), 'error'); | |||
| devErrLogSpy = sandbox.stub(dev(), 'error'); | |||
| // SRA | ||
| '7': DOUBLECLICK_EXPERIMENT_FEATURE.SRA_CONTROL, | ||
| '8': DOUBLECLICK_EXPERIMENT_FEATURE.SRA, | ||
| }[urlExperimentId]; |
There was a problem hiding this comment.
Not crazy about this, I think adding an extra line for readability is nicer.
| } | ||
|
|
||
| /** @override */ | ||
| buildCallback() { | ||
| super.buildCallback(); | ||
| const warnDeprecation = feature => user().warn( |
There was a problem hiding this comment.
I think all this warn deprecation stuff would be nicer in its own method and then just call that, rather than cluttering buildCallback with stuff that doesn't have any importance there really.
| @@ -1,216 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
AmazonPublisherServices
pushed a commit
to AmazonPublisherServices/amphtml
that referenced
this pull request
Jun 5, 2018
* initial commit * initial commit * fix compile error * fix experiment to url mapping * fix tests * remove ampdoc requirement * complete test fixes * revert changes to traffic-experiments * fix type check error * PR feedback * fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of delayed fetch deprecation cleanup, remove doubleclick-a4a-config.js as all slots are not Fast Fetch eligible. Also clean up older experiments and unused code paths.