馃悰 Register localization service in amp-story 1.0 tests #15806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
approved these changes
Jun 4, 2018
addieachan
approved these changes
Jun 4, 2018
newmuis
force-pushed
the
amp-story-test-fixes
branch
from
9f5c93d
to
0432040
Compare
newmuis
changed the title
|
Heads up @addieachan that this is merged! Hopefully you can rebase and everything will work 馃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15743 updated the tests using the wrong service (it uses the LocalizationService from 0.1). This fixes that.
It also registers the LocalizationService in more tests that were indirectly depending on it.