Avoid sanitizing 'on' attr with DOMPurify #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
force-pushed
the
purify-on-attr
branch
from
bc99846
to
7994819
Compare
alabiaga
reviewed
Jun 5, 2018
src/sanitizer.js
Outdated
| const {name, value} = r.attribute; | ||
| // Restore the `on` attribute which DOMPurify incorrectly flags as an | ||
| // unknown protocol due to presence of the `:` character. | ||
| if (name.toLocaleLowerCase() === 'on') { |
There was a problem hiding this comment.
why do we do toLocaleLowerCase? toLowerCase should suffice? Similarly in this line,
Line 300 in f52486b
There was a problem hiding this comment.
This was to be consistent with DOMPurify's internal usage, but toLowerCase should be fine. Fixed.
alabiaga
approved these changes
Jun 5, 2018
dreamofabear
force-pushed
the
purify-on-attr
branch
from
9e57a60
to
cdc4341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15721.
/to @alabiaga