Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories paused state, and state machine. #15874

Merged
merged 1 commit into from Jun 6, 2018

Conversation

gmajoulet
Copy link
Contributor

  • New story paused state
  • State machine to implement NOT_ACTIVE, ACTIVE, and PAUSED states
  • cf internal design doc

Usage:

this.storeService_.dispatch(Action.TOGGLE_PAUSED, boolean);

The paused state is not used right now, but I'll work on a PR to fix #15430. Do we want this issue to be fixed in 0.1 too?

@newmuis
Copy link
Contributor

newmuis commented Jun 6, 2018

The paused state is not used right now, but I'll work on a PR to fix #15430.

Apart from fixing #15430, are you also going to add a user gesture to set the PageState?

Do we want this issue to be fixed in 0.1 too?

No 😃 Only P0 fixes in 0.1 from now on.

@gmajoulet
Copy link
Contributor Author

Apart from fixing #15430, are you also going to add a user gesture to set the PageState?

Yup that would be really cool. Getting the right numbers to make sure we detect correctly if the gesture is a click, swipe, or long press, might require a bit of time / user testing though, but we should be able to get a prototype to play with in a couple hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-story-consent should prevent auto advance in the background.
4 participants